Skip to content

Editorial: Fix cases in validation where technically a crash could occur due to non-existent definitions #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jul 5, 2025

We have a few cases where in validation rules we rely on a different rule ensuring that the definition for usage exists.

  • Overlapping Fields, we use a Fragment Definition looked up by a SpreadName that potentially does not exist
  • VariablesOfCorrectType, we look up a VariableDefinition from a VariableName which could potentially not exist.

In GraphQL JS we already guard against this in a few places

Copy link

netlify bot commented Jul 5, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 6cc621e
🔍 Latest deploy log https://app.netlify.com/projects/graphql-spec-draft/deploys/6868d2ddff037f0008fa6a75
😎 Deploy Preview https://deploy-preview-1180--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant